Prevent goroutine leak in oidc client #11974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the stop channel returned from client.SyncProviderConfig to the oidcClient and closes the channel when the client is cleaned up. This causes the sync goroutine being run by go-oidc to end.
zmb3
reviewed
Apr 14, 2022
codingllama
approved these changes
Apr 18, 2022
codingllama
approved these changes
Apr 19, 2022
lxea
approved these changes
Apr 19, 2022
|
@rosstimothy think we can get this merged and backported by EOD tomorrow? It would be great if we can include this in 9.1.0. |
I will do my best to get it in by then. The CI gods may have other ideas |
rosstimothy
added a commit
that referenced
this pull request
Apr 19, 2022
* Prevent goroutine leak in oidc client Ensure that the goroutine spawned by client.SyncProviderConfig is terminated either by the oidc connector being removed or the server closing (cherry picked from commit 73e6242)
rosstimothy
added a commit
that referenced
this pull request
Apr 19, 2022
* Prevent goroutine leak in oidc client Ensure that the goroutine spawned by client.SyncProviderConfig is terminated either by the oidc connector being removed or the server closing (cherry picked from commit 73e6242)
rosstimothy
added a commit
that referenced
this pull request
Apr 19, 2022
* Prevent goroutine leak in oidc client Ensure that the goroutine spawned by client.SyncProviderConfig is terminated either by the oidc connector being removed or the server closing (cherry picked from commit 73e6242)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
rosstimothy
added a commit
that referenced
this pull request
Apr 19, 2022
rosstimothy
added a commit
that referenced
this pull request
Apr 19, 2022
rosstimothy
added a commit
that referenced
this pull request
Apr 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the stop channel returned from client.SyncProviderConfig to
the oidcClient and closes the channel when the client is cleaned
up. This causes the sync goroutine being run by go-oidc to end.
Fixes #11950